Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the player's theme colors in ImGui #77842

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Use the player's theme colors in ImGui #77842

merged 2 commits into from
Nov 16, 2024

Conversation

CLIDragon
Copy link
Contributor

@CLIDragon CLIDragon commented Nov 14, 2024 •
edited
Loading

Summary

Interface "ImGui inherits theme colors"

Purpose of change

fixes #75699.
Revive #76195

Describe the solution

As described in #76195.

Describe alternatives you've considered

None.

Testing

Loaded the game.

Additional context

See #76195 for more.

image

@CLIDragon @vetall812 @db48x
Use the player's theme colors in ImGui
c86395c 
Co-authored-by: vetal l <[email protected]>
Co-authored-by: Daniel Brooks <[email protected]>
@CLIDragon
Copy link
Contributor Author

Playing with this for a bit, the colors seem off for a few themes.
Kanagawa
image

@CLIDragon CLIDragon mentioned this pull request Nov 14, 2024
Open
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 14, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 14, 2024
@Night-Pryanik Night-Pryanik merged commit 63e17e4 into CleverRaven:master Nov 16, 2024
19 of 26 checks passed
This was referenced Nov 17, 2024
Merged
Merged
@CLIDragon CLIDragon deleted the imgui-theme-colors branch December 27, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Procyonae Procyonae Procyonae left review comments

@ZhilkinSerg ZhilkinSerg ZhilkinSerg left review comments

@db48x db48x db48x left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should copy colors from the user’s color theme into ImGui’s theme
5 participants
@CLIDragon @db48x @ZhilkinSerg @Procyonae @Night-Pryanik